New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use diff update on osm_transportation_merge_linestring #1357
Merged
TomPohys
merged 1 commit into
openmaptiles:master
from
makina-maps:transportation_diff_update
May 4, 2022
Merged
Use diff update on osm_transportation_merge_linestring #1357
TomPohys
merged 1 commit into
openmaptiles:master
from
makina-maps:transportation_diff_update
May 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Results evaluating commit 064a332 (merged with base 5add9a5 as 4233480). See run details. PostgreSQL DB size in MB: 2954 ⇒ 2954 (0.0% change)
expand for details...
|
Thanks @frodrigo a lot. It looks awesome. Sorry for such a delay! Could you please rebase this PR? |
frodrigo
force-pushed
the
transportation_diff_update
branch
from
April 29, 2022 20:16
b779fb4
to
064a332
Compare
Done (and all my other PR) |
TomPohys
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
REFRESH MATERIALIZED
onosm_transportation_merge_linestring_gen_z*
by differential update.The way of doing this is the same as other differential updates. But in this case there two
GROUP BY
level. So all the the process have to be done twice.Sorry for this heavy code change, but it does not make sens to split it.