Render long-distance ferries at longer zooms #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results evaluating commit da742ec (merged with base d8c367f as b3d07aa). See run details. PostgreSQL DB size in MB: 4864 ⇒ 4863 (-0.0% change)
expand for details... |
|
Thanks for the PR. Could you please also adjust the style? Would be worth it to merge the lines e.g. by |
|
|
|
Style update in 872cd71. I changed the cartography to better match how it looks in the standard tile layer: Middle zoom: Low zoom: |
ZeLonewolf
force-pushed
the
long-ferries
branch
2 times, most recently
from
6434af3
to
ae6096c
Compare
ZeLonewolf
force-pushed
the
long-ferries
branch
from
ae6096c
to
543ed53
Compare
|
I'm experimenting with merging the parallel linestrings in https://github.com/ZeLonewolf/openmaptiles/tree/zlw-coalesce-ferries, but it's really complicated and I'd like to tackle that as a separate PR so we can examine the performance/size/updates tradeoffs separately. |
TomPohys
approved these changes
Mar 15, 2023
|
Thanks! Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks ZeLonewolf/openstreetmap-americana#720
In some areas of the world, ship transportation is the main means of long-distance travel. For example, in Alaska, the Alaska Marine Highway System is the principal means of transportation through the Alaska Panhandle and down the Aleutian island chain. The AMHS carries the same importance that the Interstate Highway System has on land, and these ferry routes are exceptionally long distance.
Alaska Marine Highway System
Currently, ferries do not begin to render until zoom 11, which is inadequate for such long routes.
Lowest-zoom render of AMHS routes
Solution
This PR adds rendering for ferries down to zoom 4, which is the zoom at which the most important highways are rendered. Lower zoom (<z11) ferries are filtered so that only ferries that are of a significant length on the screen are shown.
Since ferry lines are drawn with low fidelity (few nodes), they tend to add very little size to the tiles compared to other features.
Data Render Samples
Rendered tile server (Alaska): https://6ug7hetxl9.execute-api.us-east-2.amazonaws.com/data/alaska-low-zoom/#4/56.59/-138.6
AMHS at zoom 4:
Detail added at zoom 5:
Detail at z10:
Styled tiles (OSM Americana). Clearly we could use a bit of work on the cartography but you get the idea:
