-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Performance water_name Layer #1513
Merged
TomPohys
merged 2 commits into
openmaptiles:master
from
bikemap:update_performance_water_name
Mar 22, 2023
Merged
Update Performance water_name Layer #1513
TomPohys
merged 2 commits into
openmaptiles:master
from
bikemap:update_performance_water_name
Mar 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad7902d
to
b813703
Compare
Looks good! Could you please rebase is? Thanks. |
* Refactored IDs to be unique in water_name_marine.osm_ids * Restricted updates to INSERT and UPDATE operations during water_name_marine.refresh * Added analyze statements before update queries during water_name_marine.refresh
* Implemented diff updates for update_water_lakeline.sql and update_water_point.sql * Unified update_water_lakeline.sql and update_water_point.sql to update_water_name.sql
b813703
to
7d1ab14
Compare
Have rebased and pushed |
Results evaluating commit 7d1ab14 (merged with base b2a57b3 as 037846b). See run details. PostgreSQL DB size in MB: 4926 ⇒ 4927 (0.0% change)
expand for details...
|
TomPohys
approved these changes
Mar 22, 2023
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved update performance of water_name layer
See #1433 for more detailed discussion.