Convert semi-colon separated house numbers to a range #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeLonewolf
force-pushed
the
zlw-housenumber-collapse
branch
from
a709f0d
to
74b0a52
Compare
ZeLonewolf
changed the title
1ec5
reviewed
Jul 7, 2023
| min_number int; | ||
| max_number int; | ||
| BEGIN | ||
| -- Check if the input string contains a semi-colon separator |
There was a problem hiding this comment.
It’s very common to tag addr:housenumber with a range, as an alternative to enumerating each number in the range. The most common range separator is a hyphen, although some features use to (surrounded by spaces) to avoid the ambiguity in #1558 (comment). It would make sense for the raw range separator to become an en dash too. If that sounds too easy, consider that a tag value might contain a range followed by a semicolon followed by another value.
There was a problem hiding this comment.
There is probably not a perfect processing that will work in all cases - is there logic you would suggest to handle these cases?
There was a problem hiding this comment.
If you’re comfortable with ignoring Queens-style addresses, you could replace - with ; upfront before the rest of the routine.
There was a problem hiding this comment.
That would produce very wrong results for Hawaiian addresses.
There was a problem hiding this comment.
Oh, does Hawaii use Queens-style addressing too?
There was a problem hiding this comment.
I'm not familiar with Queens-style addressing, but in Hawaii (with the exception of the city of Honolulu), all addresses are prefixed with a 2-digit code indicating what sector of the island you're at. For example, in ʻAiea the code is 99, so you would have addresses in the form 99-12 <street name>. Conceptually, if anyone's tagged semi-colon separated addresses, you could have housenumbers that might look like 99-12;99-14. Treating the hyphen/dash as a delimiter would produce either 99-14 or 12-99, both of which would be horribly wrong. Further, on just a standard address of 99-12 Whatever Street, if we treated the dash as a delimiter and sorted it, you'd end up with 12-99 which would indicate a location on a different sector of the island. So hence my concern.
There was a problem hiding this comment.
From what I've read it sounds like yes, this is the same situation as Queens-style addressing, and I don't think it would be prudent to cause bad address numbers for an entire US state.
There was a problem hiding this comment.
What if this routine avoids sorting if something looking like a range appears anywhere in the raw data? Either you could look for a hyphen and call it a day, or you could check whether the hyphen separates values in ascending order.
It’s probably worth starting a broader tagging discussion about resolving this ambiguity. I could see a case for eliminating ranges from the tagging scheme and always enumerating the middle values, as long as more renderers and geocoders introduce behavior like what you’ve implemented. However, the well-established Karlsruhe schema specifically allows for ranges. There are probably also edge cases to consider: what happens if a building is signposted with its start and end numbers but nothing in between? Ironically, you’d have to tag it as not a range in order for it to look like a range in OpenMapTiles.
There was a problem hiding this comment.
At the risk of inserting yet more en_US localization, perhaps the logic can be "if the string contains a dash, convert all semi-colons to commas", which would better serve the Queens/Hawaii problem.
|
Results evaluating commit 07297b0 (merged with base 48a2b1a as 6c12cd2). See run details. PostgreSQL DB size in MB: 4934 ⇒ 4934 (0.0% change)
expand for details... |
pnorman
reviewed
Jul 7, 2023
pnorman
reviewed
Jul 7, 2023
pnorman
previously requested changes
Jul 7, 2023
pnorman
reviewed
Aug 8, 2023
|
Thanks a lot! It looks good. Is it ready to be merged? |
|
Yes, ready here👍 |
TomPohys
approved these changes
Sep 13, 2023
kukulich
added a commit
to slevomat/openmaptiles
that referenced
this pull request
Oct 10, 2023
…ptiles#1562)" This reverts commit a7a50d8.
caiwy84
pushed a commit
to yilumistudio/openmaptiles
that referenced
this pull request
Oct 30, 2023
) This PR collapses housenumber values into the form min(housenumber)-max(housenumber) for cases where housenumber is a semi-colon separated list. If the list is all numbers, the bounds are the smallest and largest numbers. If the list includes non-numeric characters, it falls back to the first and last values in the list.
kukulich
added a commit
to slevomat/openmaptiles
that referenced
this pull request
Jan 29, 2024
…ptiles#1562)" This reverts commit a7a50d8.
kukulich
added a commit
to slevomat/openmaptiles
that referenced
this pull request
Jan 31, 2024
…ptiles#1562)" This reverts commit a7a50d8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1558
This PR collapses housenumber values into the form min(housenumber)-max(housenumber) for cases where housenumber is a semi-colon separated list. If the list is all numbers, the bounds are the smallest and largest numbers. If the list includes non-numeric characters, it falls back to the first and last values in the list.
Location (localhost link):
http://localhost:8080/data/v3/#19/41.7278712/-72.2072315