fix unexpected error brought by typo: tigger -> trigger & fix trigger_flag was created on a wrong target
#1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r_flag` was created on a wrong target
TomPohys
approved these changes
Sep 27, 2023
|
Thanks! Good catch! Looks good. |
caiwy84
pushed a commit
to yilumistudio/openmaptiles
that referenced
this pull request
Oct 30, 2023
…r_flag` was created on a wrong target (openmaptiles#1584) 1) The trigger name has a typo of `trigger`, which is incorrectly spelled as `tigger` and doesn't match the following create command: `CREATE TRIGGER trigger_flag`. This may result in an error when invoking `make import-sql`. ``` ERROR: trigger "trigger_flag" for relation "osm_park_polygon_gen_z4" already exists xargs: sh: exited with status 255; aborting ``` 2) The `trigger_flag` may be created on the wrong target in line [openmaptiles#251](https://github.com/plainheart/openmaptiles/blob/master/layers/park/update_park_polygon.sql#L251).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm just working on OpenMapTiles, it's very cool! There are two issues that may be a bug:
trigger, which is incorrectly spelled astiggerand doesn't match the following create command:CREATE TRIGGER trigger_flag. This may result in an error when invokingmake import-sql.trigger_flagmay be created on the wrong target in line #251. I think it should be an unintentional mistake. I'm sorry and will revert this change if it's not so.