Changed classification of ice_cream and chocolate #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results evaluating commit 8b858b0 (merged with base aa51a6c as b800564). See run details. PostgreSQL DB size in MB: 4939 ⇒ 4940 (0.0% change)
expand for details... |
TomPohys
approved these changes
Feb 19, 2024
|
Awesome! Thank you for digging deeper into this! |
Merged
TomPohys
pushed a commit
that referenced
this pull request
Feb 21, 2024
The main goal is to improve consistency and reduce the number of poi without an icon. - Remove music from poi cultural, music has only two subclasses music and musical_instrument, both are styled as poi shop - Remove arts_centre from poi shop, it's already styled as poi cultural - Remove chocolate icon, chocolate uses confectionery icon (see: #1628) - Remove references to ice_cream class from poi shop - Add missing gallery icon and move it to poi cultural (see: https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dgallery) - Use the icons alcohol, newsagent, perfumery, trade respectively for wine, kiosk, perfume and wholesale. - Add a generic fallback icon for shops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few days ago I made a pull request about wrongly classified confectionery under the ice_cream class. Now I noticed the problem with the ice_cream class is a little deeper.
Firstly there is a chocolate subclass under the ice_cream class, which I think doesn't belong there (as OSM tag is shop=chocolate) and should be moved to the shop class, just like confectionery.
The second, more complicated thing is ice_cream, which appears in 2 places - as a subclass of the shop class and a separate class.
I guess it was added because we have 2 different OSM tags for ice_cream, which is amenity=ice_cream and shop=ice_cream, but the problem is, that OpenMapTiles doesn't distinguish between amenity=ice_cream and shop=ice_cream, in both cases, it returns class=shop + subclass=ice_cream.
I think it makes sense to have just one ice_cream, so we can either delete the ice_cream class or the ice_cream subclass from the shop class.
According to OpenMapTiles Schema ice_cream should be a class, not a subclass of the shop, so I think it makes more sense to remove ice_cream from the shop class. I tested this, and after the change, both amenity=ice_cream and shop=ice_cream OSM tags get class=ice_cream + subclass=ice_cream, which is fine, because both OSM tags shop=ice_cream and amenity=ice_cream represents the same thing
The next thing I did was to change the color of the ice_cream icon. The reason was that after the above changes, in the default OpenMapTiles style, ice_cream falls under the poi_food layer, which has a different text color from the shop, so to make it consistent I needed to change the color of the icon, which by the way matches now with OpenStreetMap Carto.
The last thing was changing the chocolate icon in the default layer to confectionery (this icon is suggested by OSM wiki). One reason to do that was that it didn't have any icon before, the second reason was that after the above changes, chocolate fell into (in default style) poi_shop layer, which again changes the color of text, so it's better to make it consistent with the icon.