Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create boundary materialized views #740

Merged
merged 3 commits into from Jan 21, 2020

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Dec 14, 2019

Create all the needed materialized views as part of OMT, not part of the tools.

This is similar #739

nyurik added a commit to nyurik/openmaptiles that referenced this pull request Dec 14, 2019
Move materialized view creation from the tools repo.
This should be coordinated with
  openmaptiles/openmaptiles-tools#115

This PR is similar to openmaptiles#740
nyurik added a commit to nyurik/openmaptiles-tools that referenced this pull request Dec 14, 2019
Remove polygon simplification - should be done in OMT border layer

Do not merge until openmaptiles/openmaptiles#740
nyurik added a commit to nyurik/openmaptiles-tools that referenced this pull request Dec 14, 2019
Remove polygon simplification - should be done in OMT border layer

Do not merge until openmaptiles/openmaptiles#740
@MartinMikita
Copy link
Collaborator

Thanks for this PR! It would be definitely better for future or custom changes.

Would be possible to format these SQLs, so they are more readable? Probably to have selected columns in SELECT directive on a separate line? Or do you have a better suggestion to improve the readability of it?

@nyurik
Copy link
Member Author

nyurik commented Dec 16, 2019

@MartinMikita i broke it up into multiple lines, thx, good call. Note that the first two lines of each MAT VIEW will be deleted very soon, once we drop them in the tools repo, making it even more readable.

nyurik added a commit to nyurik/openmaptiles that referenced this pull request Dec 16, 2019
Move materialized view creation from the tools repo.
This should be coordinated with
  openmaptiles/openmaptiles-tools#115

This PR is similar to openmaptiles#740
nyurik added a commit to nyurik/openmaptiles-tools that referenced this pull request Dec 18, 2019
Remove polygon simplification - should be done in OMT border layer

Do not merge until openmaptiles/openmaptiles#740
nyurik added a commit to nyurik/openmaptiles-tools that referenced this pull request Dec 18, 2019
Remove polygon simplification - should be done in OMT border layer

Do not merge until openmaptiles/openmaptiles#740
@nyurik nyurik changed the title Move simplified border tables to OMT as MAT VIEWs Extract borders from data file, create mat views Dec 18, 2019
nyurik added a commit to nyurik/openmaptiles that referenced this pull request Dec 19, 2019
Move materialized view creation from the tools repo.
This should be coordinated with
  openmaptiles/openmaptiles-tools#115

This PR is similar to openmaptiles#740
@nyurik nyurik changed the title Extract borders from data file, create mat views Create boundary materialized views Dec 19, 2019
nyurik added a commit to nyurik/openmaptiles that referenced this pull request Dec 20, 2019
Move materialized view creation from the tools repo.
This should be coordinated with
  openmaptiles/openmaptiles-tools#115

This PR is similar to openmaptiles#740
nyurik added a commit to nyurik/openmaptiles-tools that referenced this pull request Jan 9, 2020
Remove polygon simplification - should be done in OMT border layer

Do not merge until openmaptiles/openmaptiles#740
nyurik added a commit to nyurik/openmaptiles-tools that referenced this pull request Jan 19, 2020
Remove polygon simplification - should be done in OMT border layer

Do not merge until openmaptiles/openmaptiles#740
nyurik added a commit to nyurik/openmaptiles that referenced this pull request Jan 19, 2020
Move materialized view creation from the tools repo.
This should be coordinated with
  openmaptiles/openmaptiles-tools#115

This PR is similar to openmaptiles#740
Consolidate derived table creation in OMT repository.
Move all non-original simplified geometry tables from import-osmborder
image to this repo, allowing further optimization.

Later we can remove derived table creation fro mthe import-osmborder image.
@nyurik nyurik requested a review from TomPohys January 20, 2020 17:22
@nyurik nyurik merged commit 1bc3f13 into openmaptiles:master Jan 21, 2020
@nyurik nyurik deleted the boundary-mat-views branch January 21, 2020 14:44
nyurik added a commit to nyurik/openmaptiles-tools that referenced this pull request Jan 21, 2020
Remove polygon simplification - should be done in OMT border layer

Do not merge until openmaptiles/openmaptiles#740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants