Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow - use insecure curl when can #838

Merged
merged 1 commit into from Apr 29, 2020

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Apr 29, 2020

Turned out that some update jobs failed due to

{
  "message": "Bad credentials",
  "documentation_url": "https://developer.github.com/v3"
}

This is probably due to credentials expiring (long workflow startup?),
or some internal github issue.

For now, removing authenticated curl calls because most
of them can be done anonymously, and keeping them only when needed.

Turned out that some update jobs failed due to

```
{
  "message": "Bad credentials",
  "documentation_url": "https://developer.github.com/v3"
}
```

This is probably due to credentials expiring (long workflow startup?),
or some internal github issue.

For now, removing authenticated `curl` calls because most
of them can be done anonymously, and keeping them only when needed.
@nyurik nyurik requested a review from TomPohys April 29, 2020 03:25
@nyurik nyurik merged commit 5f277b5 into openmaptiles:master Apr 29, 2020
@nyurik nyurik deleted the insecure-curl branch April 29, 2020 03:38
@nyurik
Copy link
Member Author

nyurik commented Apr 29, 2020

Hopefully last iterative workflow patch -- these for some reason do not reproduce elsewhere, so had to do them on OMT repo. Now should have fewer github action run errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant