New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add area-base filtering for park names in lower zoom levels #911
Conversation
Results evaluating commit 12f6e12 (merged with base ffd237d as 3b3ae12). See run details. PostgreSQL DB size in MB: 2666 ⇒ 2666 (0.0% change)
expand for details...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fine to merge. I just wish we didn't hardcode such a weird expression, but I don't know how to improve it yet.
It was shamelessly taken from openmaptiles/layers/water_name/layer.sql Line 38 in 9f4d48c
|
yes, i saw it, i was referring to that line as well - we shouldn't be using magic computations without any explanation and without anyone actually knowing what it does :). Would have been great if we either used some known functions or at least document it well. But i'm not blocking the merge, just raising a TODO for later. |
Resolve #776