Diff update osm transportation name network linestring #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results evaluating commit 995f2da (merged with base 47cdfc2 as 82d94de). See run details. PostgreSQL DB size in MB: 2665 ⇒ 2608 (-2.1% change)
expand for details... |
…le with diff update
…a table with diff update
frodrigo
force-pushed
the
diff_update_osm_transportation_name_network_linestring
branch
from
af78d8b
to
995f2da
Compare
TomPohys
reviewed
Sep 28, 2020
Comment on lines
-6
to
-9
| DROP MATERIALIZED VIEW IF EXISTS osm_transportation_name_linestring_gen1 CASCADE; | ||
| DROP MATERIALIZED VIEW IF EXISTS osm_transportation_name_linestring_gen2 CASCADE; | ||
| DROP MATERIALIZED VIEW IF EXISTS osm_transportation_name_linestring_gen3 CASCADE; | ||
| DROP MATERIALIZED VIEW IF EXISTS osm_transportation_name_linestring_gen4 CASCADE; |
There was a problem hiding this comment.
These DROPs, aren't they supposed to be in update_transportation_name.sql where the materialized views are created? In repeated make import-sql steps are rising error.
It is the same as for #987 DROP MATERIALIZED VIEW IF EXISTS osm_transportation_name_linestring CASCADE; which supposed to be in update_transportation_name.sql and not in network_type.sql and what is now rising error for repeated make import-sql.
There was a problem hiding this comment.
Here I remove the DROP MATERIALIZED, but replace it by DROP TRIGGER.
I agree this is odd. I was like this before I start working on it.
It is due because interdependencies between network_type.sql and update_route_member.sql. The two may probably need to be merged. But please, if you want to merge it, let do it after this PR.
TomPohys
approved these changes
Sep 28, 2020
|
Thanks a lot. It looks great. |
TomPohys
pushed a commit
that referenced
this pull request
Sep 28, 2020
…t version of osm object (#997) Current implementation of osm_important_waterway_linestring have two bugs: * The distinct on is_old keep the oldest version of the old object, and the oldest version of the new object, but need the last version of the new object. * Delete the old version of the object and rebuild the using the new version of the object. But we need to remove matchings the old and the new version of the object, then rebuild the two. Then only delete and update using first and last version of the object, intermediate versions are ignored. Similar implementation of what is done in #996.
|
@frodrigo, Does this code handle updates that only change the |
frodrigo
deleted the
diff_update_osm_transportation_name_network_linestring
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing materialized view by a tables with update from trigger on change only.
Differential update of
osm_transportation_name_linestring,osm_transportation_name_linestringandosm_transportation_name_linestring_genX).At the end of the transaction the dependent rows are updated.
The goal is to update more quickly the content of derivated tables by just updating the changing content. It replaces the update of materialized view because their need a full recompute (with lock issue).
It is the last part of the replacement of materialized view for the transportation layer.
It addresses #814 and a part of #809.