Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lake IDs at low zooms #15

Open
msbarry opened this issue Jul 29, 2022 · 1 comment
Open

Lake IDs at low zooms #15

msbarry opened this issue Jul 29, 2022 · 1 comment

Comments

@msbarry
Copy link
Collaborator

msbarry commented Jul 29, 2022

As part of onthegomap/planetiler#227, I added lake OSM IDs but only for lakes from OSM data (z6 and above). Merging with natural earth data is a bit tricky because we process all of natural earth first, then all of openstreetmap.

A few options for how to get OSM IDs on low-zoom lakes:

  • store all of the natural earth lakes features in-memory in water profile, add additional info to them while processing OSM elements, then write them out after OSM is finished (like we do with the boundary layer)
  • Use OSM lakes at lower zoom-levels instead of natural earth. We could add VW simplification with options like effective/weighted area to planetiler to produce a similar visual effect that natural earth gets with mapshaper
  • Extract OSM IDs as part of wikidata pre-processing, then go from wikidata ID to OSM ID when processing natural earth elements

Originally posted by @msbarry in onthegomap/planetiler#227 (comment)
Transferred from onthegomap/planetiler#231

@mmc1718
Copy link

mmc1718 commented Jul 28, 2023

Edit: Coming back to this I don't think this is related. If it's still of interest I can make a separate issue and PR for that.

I am working on a project which involves using Planetiler (the OMT profile) and editing the WaterName layer to get lake labels for certain lakes in the natural earth dataset to show from the zoom specified by min_label in the ne dataset.

I found this issue and am wondering if it is related. I am currently using the same approach as for marine points (storing wikidata ids and matching them to the OSM elements

private final ConcurrentSkipListMap<String, Integer> importantMarinePoints = new ConcurrentSkipListMap<>();
)

I am not sure how this approach compares to the suggested options listed here for the Water layer. My priority is to have labels available at low zooms for the significant lakes, rather than add more lakes to the map.

I would be interested to know whether you see this task as overlapping? If so, I would be happy to work on a PR (also happy to take a different approach to the one I am working on currently if it is preferred)

cboone pushed a commit to cboone/planetiler-openmaptiles that referenced this issue Dec 2, 2023
…_sync_and_java_code_regeneration

Java code regenerated from latest OMT YML
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants