-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support colon in field names #56
Conversation
https://github.com/openmaptiles/planetiler-openmaptiles/actions/runs/3811714457 ℹ️ Base Logs c662ef2
ℹ️ This Branch Logs 61b574584553456b5ef92ee8d86d382a9f8b75ae
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any possibility of 2 keys conflicting? For example name_en
and name:en
Theoretically yes. |
Awesome, thanks I think that would make it a bit safer. |
PR fixed with double |
Confirmed on https://taginfo.openstreetmap.org/tags that it doesn't look like any keys/values use |
Change I need to do to support colon
:
in generated code in some fields name of my OpenMapTiles fork.There is possible some other places sensible to colon char.
In my case, rename fields is not an option, as I try to port to Planetiler an already existing OpenMapTiles fork, and I want to keep some OSM tag names.