Added checks that tolerance value is between 0 and 1 (#2884)

openmc-dev · Feb 26, 2024 · b3a2456 · b3a2456
1 parent e8f68a0
commit b3a2456
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/openmc/stats/univariate.py b/openmc/stats/univariate.py
@@ -280,6 +280,9 @@ def clip(self, tolerance: float = 1e-6, inplace: bool = False) -> Discrete:
         Discrete distribution with low-importance points removed
 
         """
+        cv.check_less_than("tolerance", tolerance, 1.0, equality=True)
+        cv.check_greater_than("tolerance", tolerance, 0.0, equality=True)
+
         # Determine (reversed) sorted order of probabilities
         intensity = self.p * self.x
         index_sort = np.argsort(intensity)[::-1]

diff --git a/tests/unit_tests/test_stats.py b/tests/unit_tests/test_stats.py
@@ -89,6 +89,12 @@ def test_clip_discrete():
     d_same = d.clip(1e-6, inplace=True)
     assert d_same is d
 
+    with pytest.raises(ValueError):
+        d.clip(-1.)
+
+    with pytest.raises(ValueError):
+        d.clip(5)
+
 
 def test_uniform():
     a, b = 10.0, 20.0