-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuously Varying Material Tracking Method (CVMT) Implementation #1358
Open
rockfool
wants to merge
16
commits into
openmc-dev:develop
Choose a base branch
from
rockfool:cvmt
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4cafc29
add CVMT method in neutron transport
rockfool d056e52
Merge remote-tracking branch 'upstream/develop' into cvmt
rockfool de0ad46
fix a bug in cvmt sampling
rockfool 88cceb1
remove the duplicate zernike function
rockfool 592bcf0
change fixed array to std::vector in material.h and cpp
rockfool c8ce1e2
remove debugging stuff
rockfool 5920d73
remove fet_order from settings.h
rockfool b3f4b83
add documentation for cvmt method
rockfool 3bd6bfb
change figures extension
rockfool 227809f
add regression_test case for cvmt
rockfool b26149f
modify function name in test.py
rockfool dad6df9
change printf to warning function in error.h
rockfool 5f9c13f
resolve conflict in particle class
rockfool 63a10fa
bug fix in resolved confliction
rockfool cf34d86
remove useless function definition
rockfool c850e4a
fix the conflict on tally_scoring
rockfool File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,3 +10,4 @@ | |
[submodule "vendor/xtl"] | ||
path = vendor/xtl | ||
url = https://github.com/xtensor-stack/xtl.git | ||
|
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -231,6 +231,19 @@ class Particle { | |
//! \param src Source site data | ||
void from_source(const Bank* src); | ||
|
||
//! Transport a particle from birth to death | ||
void transport(); | ||
|
||
//! cvmt sampling: continuous varying materials tracking | ||
double sampling_cvmt(Particle* p, double d_boundary); | ||
void move_particle_coord(LocalCoord& coord, double ds); | ||
void simpsons_path_integration(double& optical_depth, double distance, std::vector<double> &xs_t, bool dbg_file, int it_num); | ||
void estimate_flight_distance(std::vector<double> xs_t, double distance, double tau_hat, double& s); | ||
void get_quadratic_root(double a, double b, double c, double lower_b, double upper_b, double& root); | ||
void get_cubic_root(double a, double b, double c, double d, double lower_b, double upper_b, double& root); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For all these functions/methods, you need to add Doxygen comments above describing what the parameters are |
||
double sign(double aa, double bb); | ||
void copy_data(LocalCoord& to, LocalCoord from); | ||
|
||
// Coarse-grained particle events | ||
void event_calculate_xs(); | ||
void event_advance(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NL.16: Put public members before private