Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and generalize the boundary condition implementation #1701

Merged
merged 22 commits into from
Dec 22, 2020
Merged

Refactor and generalize the boundary condition implementation #1701

merged 22 commits into from
Dec 22, 2020

Commits on Oct 18, 2020

  1. Move BC tracking software into separate functions

    @smharper
    smharper committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    0f214eb View commit details
    Browse the repository at this point in the history

  2. Move reflective/white BCs to a new class

    @smharper
    smharper committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    05ea9ea View commit details
    Browse the repository at this point in the history

  3. Move all BCs to the new BoundaryCondtion class

    @smharper
    smharper committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    1d07f49 View commit details
    Browse the repository at this point in the history

  4. Add surface indices to the PeriodicBC class

    @smharper
    smharper committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    58a0aa3 View commit details
    Browse the repository at this point in the history

  5. Move periodic translation from Surface class to BC

    @smharper
    smharper committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    16d4c58 View commit details
    Browse the repository at this point in the history

  6. Move rotational periodic BCs to the new class 

    Remove the now unnecessary Surface::periodic_translate function.
    @smharper
    smharper committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    8e6842d View commit details
    Browse the repository at this point in the history

  7. Remove the PeriodicSurface class

    @smharper
    smharper committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    2fa449d View commit details
    Browse the repository at this point in the history

  8. Remove the old Surface::bc_ attribute

    @smharper
    smharper committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    593a4ad View commit details
    Browse the repository at this point in the history

  9. Reimplement SurfacePlane translational BCs

    @smharper
    smharper committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    fe0cffe View commit details
    Browse the repository at this point in the history

  10. Add general plane support for rotational BCs

    @smharper
    smharper committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    b64a3d3 View commit details
    Browse the repository at this point in the history

  11. Increase periodic BC test coverage

    @smharper
    smharper committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    b403f87 View commit details
    Browse the repository at this point in the history

  12. Add docstrings to boundary_condition.h

    @smharper
    smharper committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    f060b4e View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. Update BCs for DAGMC surfaces

    @smharper
    smharper committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    fb8bae8 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
    @smharper @paulromano
    smharper and paulromano committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    1af80b1 View commit details
    Browse the repository at this point in the history

  2. Add comments to periodic BC implementation

    @smharper
    smharper committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    5fb806b View commit details
    Browse the repository at this point in the history

  3. Simplify pairing logic for periodic surfaces

    @smharper
    smharper committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    803ae8d View commit details
    Browse the repository at this point in the history

  4. Remove unneeded plot from periodic BC test

    @smharper
    smharper committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    c75790d View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2020

  1. Assume un-aligned normals for rotational BCs

    @smharper
    smharper committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    a8ecb79 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2020

  1. Fix non-90-degree rotational periodic BCs

    @smharper
    smharper committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    f8c7a74 View commit details
    Browse the repository at this point in the history

  2. Add a test for non-90-degree periodic BCs

    @smharper
    smharper committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    6ed023c View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/develop' into bc_update

    @smharper
    smharper committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    8879414 View commit details
    Browse the repository at this point in the history

  4. Add missing test __init__.py

    @smharper
    smharper committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    b03b983 View commit details
    Browse the repository at this point in the history