Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a few small bug fixes:
table_name
when calingThermalScattering.from_njoy
and it won't try to guess a nameMaterials.cross_sections
(but not settingOPENMC_CROSS_SECTIONS
) they ran into an exception. It turns out that theOperator._get_nuclides_with_data
method always tried to find what nuclides have neutron data by just looking at the environment variable but notMaterials.cross_sections
. This has been fixed in this PR and I've tried to better encapsulate the logic for finding cross sections / depletion chains into single places (the_find_cross_sections
and_find_chain_file
functions).