Adding ecco 1968 energy group #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
requested changes
Aug 17, 2022
There was a problem hiding this comment.
Thanks @shimwell! One little fix and this should be good to go
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
paulromano
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the openmc forum here is a proposed addition for the ECCO-1968 group structure.
Sometimes this is called "ECCO-2000 a fine 1968 group structure" e.g. here
However the most accessible reference I could find calls it the ECCO-1968 group structure and so does the example in the openmc forum so I opted for this name as it is perhaps less confusing.