Add support for ncrystal materials #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here there is a simple example |
paulromano
requested changes
Mar 23, 2023
There was a problem hiding this comment.
Thanks for implementing this @zoeprieto! It looks like there is a conflict in plotter.py due to the recently merged PR #2413, so you'll need to merge in the latest develop branch into your branch and resolve the conflicts.
| import NCrystal | ||
| nc_scatter = NCrystal.createScatter(ncrystal_cfg) | ||
| nc_func = nc_scatter.crossSectionNonOriented | ||
| nc_emax = 5 # eV # this should be obtained from NCRYSTAL_MAX_ENERGY |
There was a problem hiding this comment.
I think there was some discussion about having the max energy be configurable, but I forget where we ended up on this. @tkittel Do you recall? In any event, I'm fine with the hard-coded value for now.
Added description of ncrystal_cfg
Update branch
|
Hey @paulromano , I incorporated the changes to my branch. Can you please review it again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to fix the issue #2422. The changes are simple but one remaining point would be to obtain the maximum NCrystal energy from the C API. @paulromano how can we access the API to obtain NCRYSTAL_MAX_ENERGY?