Implement composite surface for generalized cruciform prism #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eepeterson
requested changes
Apr 24, 2023
|
@eepeterson Thanks for the review; just addressed your comments. |
eepeterson
reviewed
Apr 24, 2023
eepeterson
requested changes
Apr 24, 2023
Co-authored-by: Ethan Peterson <ethan.peterson@mit.edu>
eepeterson
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new composite surface called
CruciformPrismthat is equivalent to the gcross derived surface in Serpent. Rather than try to describe what this surface is, the image given on the Serpent website gives a good idea of the resulting shape:In the implementation here, you create the cruciform prism by giving a list of distances, e.g.,
Optional arguments allow you to specify the center of the prism as well as the corresponding axis to which it is parallel (defaults to z-axis).
Special thanks to Fausto Malvagi for requesting this surface! 馃檹