New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding optional outline to plots #2482
adding optional outline to plots #2482
Conversation
looks like the CI is failing for reasons unrelated to the PR, looks like there is a fix in already so I can rerun the CI after #2481 has been merged in |
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
canceled the CI for the previous run as I had one more commit to sneak into this PR. Latest commit just improves the pytest a little bit |
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good now; thanks @shimwell!
This PR attempts to add outlines to the universe.plot method.
I had this functionality over in the openmc-geometry-plot package and thought it would be much better over here ♻️
Also inspired by @gridley and @pshriwise recent PR which improves the universe plot method.
before this PR
after this PR using optional
outline
Minimal script for using this
outline
feature