New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding BoundingBox.extent and RegularMesh.bounding_box #2507
Merged
paulromano
merged 15 commits into
openmc-dev:develop
from
shimwell:adding_bb_to_mesh_and_extent_to_bb
May 22, 2023
Merged
adding BoundingBox.extent and RegularMesh.bounding_box #2507
paulromano
merged 15 commits into
openmc-dev:develop
from
shimwell:adding_bb_to_mesh_and_extent_to_bb
May 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o adding_outlines_to_mesh_plot
shimwell
commented
May 2, 2023
shimwell
commented
May 2, 2023
Sorry for this mess of a PR, I accidentally merged a few branches together. I've tidied it up now. Great example of why squashing commits on merge is the way to go 😄 |
shimwell
commented
May 2, 2023
paulromano
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple enough -- thanks @shimwell!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm plotting a few regular meshes at the moment and would find it useful to be able to easily get the extent of the regular mesh.
Adding a
bounding_box
property to theRegularMesh
and adding theextent
property to theBoundingBox
would make it easier when plotting.example usage.