Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove initial dilute nuclides in MicroXS #2579

Merged
merged 3 commits into from Jun 29, 2023

Conversation

paulromano
Copy link
Contributor

Description

This PR removes the dilute_initial option in the MicroXS.from_model classmethod (#2568 already removed dilute_initial elsewhere in the depletion solver). Additionally, I've added nuclides and reactions arguments to MicroXS.from_model that make it easier to customize what nuclides/reactions you want to get microscopic cross sections for. When they are omitted, the behavior defaults to the current behavior where the nuclides/reactions are determined from the depletion chain.

Checklist

  • I have performed a self-review of my own code
  • [ ] I have run clang-format on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@yardasol yardasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @paulromano,
Good work on this nice short change. I just have one question w.r.t. the tests.

tests/regression_tests/microxs/test.py Show resolved Hide resolved
@yardasol yardasol self-requested a review June 29, 2023 09:03
Copy link
Contributor

@yardasol yardasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @paulromano!

openmc/deplete/microxs.py Show resolved Hide resolved
@yardasol yardasol merged commit 36f229e into openmc-dev:develop Jun 29, 2023
18 checks passed
@paulromano paulromano deleted the microxs-no-dilute branch June 29, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants