time-cutoff version 2.0 #2631
Merged
time-cutoff version 2.0 #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
reviewed
Aug 18, 2023
There was a problem hiding this comment.
@cfichtlscherer Many apologies for the delay in reviewing this! Just one comment/question:
paulromano
approved these changes
Aug 19, 2023
|
Thanks a lot for reviewing! And nice to have this feature added. |
stchaker
pushed a commit
to stchaker/openmc
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm very sorry to open a new pull-request for this, but something is wrong with the old one and I can't figure out what's wrong even after several hours (among other things, clang-format error is issued for lines I haven't edited).
The original pull-request can be found here: #2454.
I know this is not optimal, but I have added all the changes here again.
Checklist