Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cross_sections for element expansion in Material.add_element() #2633

Merged
merged 2 commits into from Aug 19, 2023

Conversation

joshmay1
Copy link
Contributor

@joshmay1 joshmay1 commented Aug 8, 2023

Description

Allows for the cross_sections to be specified while adding elements to a material. Previously, the only way to do this was to set the OPENMC_CROSS_SECTIONS env variable or by setting the openmc.config.

Checklist

  • [ ] I have performed a self-review of my own code
  • [ ] I have run clang-format on any C++ source files (if applicable)
  • [ ] I have followed the style guidelines for Python source files (if applicable)
  • [ ] I have made corresponding changes to the documentation (if applicable)
  • [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joshmay1!

@paulromano paulromano enabled auto-merge (squash) August 18, 2023 21:09
@paulromano paulromano merged commit 471caa5 into openmc-dev:develop Aug 19, 2023
18 checks passed
stchaker pushed a commit to stchaker/openmc that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants