allowing different volume methods for diff mat #2691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A while back I tried PR #2653 but this changed the behaviour of the diff_burnable_mat too much for it's main use case.
diff_burnable_mat
appears to be doing two things when set to True, it changes the materials volumes and makes extra materials. This PR attempts to separate out both of these things and allow the user to specify each oneThis PR is an attempt to add another argument to CoupledOperator so that the manner in which the volume is found can be user specified. This maintains current behavior as default when diff_burnable_mat is set to True but also allows users to split up the materials so that their volumes are assigned to the cell volume instead of always being divided equally.
This PR attempts to add another argument called
diff_volume_method
which can be set to "divide equally" (default) or "match cell" (useful for fusion r2s and burn up)Fig 6 in this fantastic paper 馃槃 suggests we get about 20% burn up at the front of DEMO reactor solid breeder blankets. Hence I'm keen to see the CoupledOperator working in this slightly different way for fusion simulations.
Fixes # (issue)
Checklist