Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that property setters are used in CylindricalMesh and SphericalMesh #2709

Merged
merged 4 commits into from Sep 27, 2023

Conversation

paulromano
Copy link
Contributor

Description

I noticed that the constructors for CylindricalMesh and SphericalMesh were directly setting _r_grid, _phi_grid, etc. instead of going through the properties, which perform checks on the values. This PR fixes and makes corresponding changes in the tests.

I've also included a few small fixes for warnings that were being raised during tests.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates @paulromano. 🧇's rule.

@pshriwise pshriwise merged commit 0c6da38 into openmc-dev:develop Sep 27, 2023
18 checks passed
@paulromano paulromano deleted the mesh-grid-setters branch September 27, 2023 11:17
stchaker pushed a commit to stchaker/openmc that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants