New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved diff_burnable_mat to model #2718
Merged
paulromano
merged 3 commits into
openmc-dev:develop
from
shimwell:adding_diff_depletable_materials_to_model
Oct 17, 2023
Merged
moved diff_burnable_mat to model #2718
paulromano
merged 3 commits into
openmc-dev:develop
from
shimwell:adding_diff_depletable_materials_to_model
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
requested changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea @shimwell 👍 two comments below:
shimwell
commented
Oct 10, 2023
shimwell
commented
Oct 10, 2023
shimwell
commented
Oct 10, 2023
shimwell
commented
Oct 10, 2023
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
updating branch with fix on develop
Thanks for fixing the tests @pshriwise Looks like this PR is now passing the tests again. https://github.com/openmc-dev/openmc/actions/runs/6506983030 |
3 tasks
paulromano
approved these changes
Oct 17, 2023
stchaker
pushed a commit
to stchaker/openmc
that referenced
this pull request
Oct 25, 2023
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It would be useful for cell based R2S simulations to be able to call
diff_burnable_mats
on theModel
class. Then users can callmodel.diff_burnable_mats
before calling a volume calculation. It is useful to carry out a volume calculation to get the cell/material volumes needed for depletion simulations after the materials have been diffed. Full motivation in #2714Would it be acceptable to move the function to the model.py? We do have a few other methods that operate on materials in the Model class like
update_material_volumes
.This would not change or break behavior for users that want to diff_burnablemats when calling the deplete method
Fixes # (issue)
#2714
Checklist