Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum Python version to 3.8 #2958

Merged
merged 8 commits into from
Apr 15, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ jobs:
vectfit: [n]

include:
- python-version: "3.7"
omp: n
mpi: n
- python-version: "3.8"
omp: n
mpi: n
Expand All @@ -47,6 +44,9 @@ jobs:
- python-version: "3.11"
omp: n
mpi: n
- python-version: "3.12"
omp: n
mpi: n
- dagmc: y
python-version: "3.10"
mpi: y
Expand Down
2 changes: 1 addition & 1 deletion docs/source/devguide/styleguide.rst
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ Style for Python code should follow PEP8_.

Docstrings for functions and methods should follow numpydoc_ style.

Python code should work with Python 3.7+.
Python code should work with Python 3.8+.

Use of third-party Python packages should be limited to numpy_, scipy_,
matplotlib_, pandas_, and h5py_. Use of other third-party packages must be
Expand Down
2 changes: 1 addition & 1 deletion docs/source/usersguide/install.rst
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ to install the Python package in :ref:`"editable" mode <devguide_editable>`.
Prerequisites
-------------

The Python API works with Python 3.7+. In addition to Python itself, the API
The Python API works with Python 3.8+. In addition to Python itself, the API
relies on a number of third-party packages. All prerequisites can be installed
using Conda_ (recommended), pip_, or through the package manager in most Linux
distributions.
Expand Down
7 changes: 3 additions & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,19 +53,18 @@
'Topic :: Scientific/Engineering'
'Programming Language :: C++',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
'Programming Language :: Python :: 3.12',
],

# Dependencies
'python_requires': '>=3.7',
'python_requires': '>=3.8',
'install_requires': [
'numpy>=1.9', 'h5py', 'scipy', 'ipython', 'matplotlib',
'pandas', 'lxml', 'uncertainties'
'pandas', 'lxml', 'uncertainties', 'setuptools'
],
'extras_require': {
'depletion-mpi': ['mpi4py'],
Expand Down
4 changes: 3 additions & 1 deletion tools/ci/gha-install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ fi
# For MPI configurations, make sure mpi4py and h5py are built against the
# correct version of MPI
if [[ $MPI == 'y' ]]; then
pip install --no-binary=mpi4py mpi4py
# setuptools 69.4.0 causes problems with mpi4py installation
pip install --upgrade "setuptools<69.4.0" build wheel
shimwell marked this conversation as resolved.
Show resolved Hide resolved
pip install --no-build-isolation --no-binary=mpi4py mpi4py

export CC=mpicc
export HDF5_MPI=ON
Expand Down