Allow MeshSource to take a 1D array of sources #2980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, the
MeshSource
class requires that when you provide sources for each element of a structured mesh, you pass it a multidimensional array that has the same shape as the mesh. So, if you have aRegularMesh
withmesh.dimension = (10, 2, 5)
, then the array of sources also has to be of shape(10, 2, 5)
. This PR allows you to pass a flat array of sources in the order of the mesh element indices. This makes it a more mesh agnostic since the same interface can be used for both structured and unstructured meshes (passing a flat array).Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)