Use 'earliest' libver with h5py for backwards-compatibility #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
requested changes
Dec 17, 2017
There was a problem hiding this comment.
I agree this would ease some user pain. However, I'd like to retain an option to generate libraries using the latest format because there are some important performance improvements in the 1.10 format specifically for HPC (outlined here). What I would suggest is to add a libver keyword argument to IncidentNeutron.export_to_hdf5 and ThermalScattering.export_to_hdf5 that defaults to 'earliest'. I'm not sure it's important for the other classes, so I'll leave it up to you whether you want to include it for the others.
paulromano
reviewed
Dec 18, 2017
scripts/openmc-convert-mcnp71-data
Outdated
| @@ -28,6 +28,9 @@ parser.add_argument('-d', '--destination', default='mcnp_endfb71', | |||
| help='Directory to create new library in') | |||
| parser.add_argument('-f', '--fission_energy_release', | |||
| help='HDF5 file containing fission energy release data') | |||
| parser.add_argument('--latest_hdf5', help='Use latest HDF5 format for ' | |||
There was a problem hiding this comment.
How about:
parser.add_argument('--libver', choices={'earliest', 'latest'}, default='earliest', ...)
paulromano
approved these changes
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #940. This PR asks h5py to output HDF5 files in the most backwards-compatible format possible. Twice we've had new users unable to get going from a fresh install of OpenMC because Anaconda3 uses a higher version for HDF5 than the Ubuntu defaults. Plus, it's easy to get your HDF5 versions out-of-sync when you use many different machines.
I tested this on the NNDC U-235 data and it only increases file size from 4.3 MB to 4.7 MB---a price well worth paying in my opinion.