Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "mphys_" prefix from files, classes, and methods. #30

Closed
joanibal opened this issue Jun 17, 2020 · 1 comment · Fixed by #39
Closed

Remove "mphys_" prefix from files, classes, and methods. #30

joanibal opened this issue Jun 17, 2020 · 1 comment · Fixed by #39

Comments

@joanibal
Copy link
Collaborator

Python already provides a clear way of using namespaces through modules.
As a result the mphys_ prefix for files, classes, and methods used in the mphys module is redundant.

I propose removing the mphys_ prefix present throughout the code within the mphys repo. Although, for files like mphys_adflow.py which will eventually be moved back to the main code repo I think it does make sense to keep the prefix since it will be moved outside of the module eventually.

@JustinSGray
Copy link
Member

this is a tough subject. Python does have name-spacing, but because you inherit from Group/Component its not always inherantly clear if a method is part of the base OpenMDAO API or part of the mphys additions.

This issue came up a lot in the OAS work. My opinion is that there is some real value in making a clear distinction between mphys methods, and standard OM methods...

@joanibal joanibal linked a pull request Jul 13, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants