Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo clean up #39

Merged
merged 12 commits into from
Jul 21, 2020
Merged

Repo clean up #39

merged 12 commits into from
Jul 21, 2020

Conversation

kejacobson
Copy link
Collaborator

Changes towards cleaning up some of the existing code:

  1. Class names are converted to CamelCase to meet PEP-8 conventions
  2. The tacs object is renamed from tacs to tacs_assembler to avoid name conflict with the tacs module being imported.
  3. To address issue Remove "mphys_" prefix from files, classes, and methods. #30, several mphys_ prefixes have being removed from file names and class names. Files that will move to other repositories still have the prefix as well as mphys specific methods added to OpenMDAO groups/components.

@kejacobson kejacobson changed the title Repo clean up WIP: Repo clean up Jul 13, 2020
@kejacobson
Copy link
Collaborator Author

Needs to be tested on the examples before merging

@joanibal joanibal linked an issue Jul 13, 2020 that may be closed by this pull request
Copy link
Collaborator

@joanibal joanibal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kevin!

The only inconsistency that I could find was in the capitalization of VLM in DummyVLMSolver. It seems like it should be DummyVlmSolver to match VlmGroup and VlmBuilder

@kejacobson
Copy link
Collaborator Author

Thanks for reviewing it Josh. I've made the dummy VLM solver name consistent.

…the adflow wrapper and (temporarily) made it an option to the builder. minor updates to one runscript
@anilyil
Copy link
Collaborator

anilyil commented Jul 16, 2020

thanks for the work @kejacobson I have pushed 2 commits:

First one also updates the name of the SolverGroup the way you updated other mphys groups.

The second commit is related to typo fixes in adflow wrapper. I realized I enabled the propulsion "hooks" in adflow on by default, I disabled this by default and it is now activated via an input parameter to the builder. I know other builders may not have input parameters to the builder but I wanted to have these custom for adflow; default behavior is same across other builders, and I can specialize it for my cases. If we want to create a default mphys api for this type of stuff, I can modify the adflow wrapper again.

After my changes, all examples under mach_tutorials folder works as expected. If you also approve my changes in the last 2 commits, I think this PR is ready to be merged.

@kejacobson kejacobson changed the title WIP: Repo clean up Repo clean up Jul 21, 2020
@kejacobson kejacobson merged commit ec5e6b0 into OpenMDAO:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "mphys_" prefix from files, classes, and methods.
3 participants