-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo clean up #39
Repo clean up #39
Conversation
- change tacs object name to tacs_assembler - class names to pep 8 style (CamelCase)
- pep 8 class names - shorten some long lines
Conflicts: examples/mach_tutorials/aero_opt/mphys_aero.py examples/mach_tutorials/aero_opt/mphys_aero_2pt.py mphys/mphys_adflow.py
Needs to be tested on the examples before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kevin!
The only inconsistency that I could find was in the capitalization of VLM
in DummyVLMSolver
. It seems like it should be DummyVlmSolver
to match VlmGroup
and VlmBuilder
Thanks for reviewing it Josh. I've made the dummy VLM solver name consistent. |
…the adflow wrapper and (temporarily) made it an option to the builder. minor updates to one runscript
thanks for the work @kejacobson I have pushed 2 commits: First one also updates the name of the SolverGroup the way you updated other mphys groups. The second commit is related to typo fixes in adflow wrapper. I realized I enabled the propulsion "hooks" in adflow on by default, I disabled this by default and it is now activated via an input parameter to the builder. I know other builders may not have input parameters to the builder but I wanted to have these custom for adflow; default behavior is same across other builders, and I can specialize it for my cases. If we want to create a default mphys api for this type of stuff, I can modify the adflow wrapper again. After my changes, all examples under mach_tutorials folder works as expected. If you also approve my changes in the last 2 commits, I think this PR is ready to be merged. |
Changes towards cleaning up some of the existing code:
tacs
totacs_assembler
to avoid name conflict with thetacs
module being imported.