Fix cron script of recyclebin delete #55
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On server with openmediavault package 3.0.96 I found that never clean the recycle of all shares even if setted correctly (causing big problems of full disks).
After have investigated I found that /var/lib/openmediavault/cron.d/samba-recycle-* file executed manually always exit with status 0 without delete the files that must delete (even if find commands work correctly), exit with both lock dir exist and not.
This PR solves this problem (simpler and faster solution that came to my mind, already tested)
When will be applied can be backported also to 3.0.x please?