Export all layers of the prior in omGeoJSON.py #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aethr
commented
Jul 1, 2024
aethr
commented
Jul 1, 2024
lewisjared
approved these changes
Jul 1, 2024
|
|
||
| # There is a better way to do this but this will work for now | ||
| # Using xarray wasn't straightforward because the layers don't use | ||
| # the same attribute names, ie mixing x/y and lat/long. |
There was a problem hiding this comment.
That needs to be fixed. The naming is incorrect, but the dimensions are the right size which makes it harder to handle than it should
There was a problem hiding this comment.
Agree, but not within the scope of this change. The code here should continue to work after layer names are changed due to its simplicity, so I'd like to leave it as-is for now.
This script is still just used as a debugging script, but exporting all layers gives us more data to debug with.
Instead of writing out identical operations for each layer of the prior, use a list of known layers and apply the same logic to each layer programmatically.
These are aliases of the same function but max is more commonly used and understood.
aethr
force-pushed
the
prior-geo-json-layers
branch
from
2c7edba
to
2d500ca
Compare
This typo caused python to construct a list instead of a single value.
By including the max values of each layer once as metadata, each grid cell's relative value can be calculated on the fly. It also makes it easier to understand the relative scale of each layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This script is still just used as a debugging script, but exporting all layers gives us more data to debug with.
On one hand, we can visualise each layer distinctly in the front-end, allowing each layer to be checked visually. As a secondary benefit, each layer provides a distinct but realistic example of methane emissions that can be used as mock data for front-end development.
Checklist
Please confirm that this pull request has done the following:
Tests addedDocumentation added (where applicable)Note: I have not added tests, as this file is still only useful for debugging and I do not believe it forms part of the production workflow.
Notes
I attempted to update this script to work more like omDomainJSON.py which uses xarray to select the specific NetCDF layers we're interested in, however that approach wasn't easy because the variables in the prior output file don't all share the same dimensions.