Adding CONTRIBUTING file to BF repo #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis build is failing on the CPP build so not related to this PR. |
|
Re-launched travis. Perhaps time for a check, @sbesson, to detect when a file is docs only and not run the other builds? 😄 |
|
Only minor thing is that I'm not sure we want to advertise a 2 business day review policy, but I'm happy to be outvoted. All looks fine to me otherwise. |
|
I did wonder about that given we have less reviewers on the BF side, happy to change it to indicate we get to things as quickly as we can instead? |
|
Reads fine to me. All links worked. Good to merge. |
|
--rebased-to #1076 |
melissalinkert
added a commit
that referenced
this pull request
May 1, 2014
Adding CONTRIBUTING file to BF repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket 10030 fix - adding a contributing file which is pointed out to GH users who open an issue or PR against the BF repo.