Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude log4j and packages from target-test-runner #1080

Merged
merged 1 commit into from May 15, 2014

Conversation

melissalinkert
Copy link
Member

This is intended to fix https://trac.openmicroscopy.org.uk/ome/ticket/12114. Running ant clean jars tools and then cd components/test-suite && ./target-test-runner loci.tests.testng.OpenBytesPerformanceTest /path/to/test/file should produce more *.log files in components/test-suite than the same command without this PR merged.

It's also important to verify that the performance builds remain green with this PR included.

@bpindelski
Copy link

http://ci.openmicroscopy.org/view/Bio-Formats/job/BIOFORMATS-5.0-merge-openbytes-performance/ looks green, although I can't view the job's details, as Jenkins times out. I wonder if it's because of too many test results being rendered in the UI?

That brings me to the second point - with this PR included, bioformats_package.jar loci_tools.jar andlog4j are not included on the CP generated by target-test-runner. The amount of *.log files remains the same though - when running

./target-test-runner loci.tests.testng.OpenBytesPerformanceTest /Users/bpindelski/Desktop/testing/import/leica/tropo/tropo.lei

I still get two log files as a result. The contents of those files between dev_5_0 and the merge build doesn't differ. Additionally, logback (on both branches) gives me an error:

10:39:34,782 |-ERROR in ch.qos.logback.core.pattern.parser.Compiler@6195bb34 - There is no conversion class registered for conversion word [x]
10:39:34,782 |-ERROR in ch.qos.logback.core.pattern.parser.Compiler@6195bb34 - [x] is not a valid conversion word

which causes each line of both log files to contain this string: %PARSER_ERROR[x]. If I'm doing something wrong, then sorry for the noise...

@bpindelski
Copy link

Jenkins started showing http://ci.openmicroscopy.org/view/Bio-Formats/job/BIOFORMATS-5.0-merge-openbytes-performance/ again. I can confirm that the test-suite-results.tar.gz also contains log files with the parser error.

@bpindelski
Copy link

Summing up: if the same number of log files and parser error aren't blockers, this is OK to merge.

@melissalinkert
Copy link
Member Author

Merging as-is. On closer reading of the ticket, this is probably more important for develop/5.1 jobs, but it can't really hurt here.

melissalinkert added a commit that referenced this pull request May 15, 2014
Exclude log4j and packages from target-test-runner
@melissalinkert melissalinkert merged commit f64fd89 into ome:dev_5_0 May 15, 2014
@melissalinkert
Copy link
Member Author

--rebased-to #1107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants