Add initial support for reading BinaryOnly OME-TIFF datasets #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adjusts the type detection slightly so that .companion.ome files are detected as OME-TIFF, not OME-XML (as this makes finding and reading the corresponding OME-TIFF files much easier). Selecting either a BinaryOnly OME-TIFF file or the corresponding companion OME-XML file should result in the entire dataset being read. Fixes #11951.
|
|
If its just at the level of reading alone. The OMETiffReader is reading the files, but the import does not happen. Is this the expectation? |
|
I don't follow what you mean by the import not happening when the |
|
Yes The images do not appear on insight post refreshing. Apologies for not stating that clearly. |
Some Prairie datasets contain "OME-TIFF" files with a BinaryOnly entry that points to a different "OME-TIFF", which is not valid.
|
I assume you were importing into nightshade? Has that been upgraded with this morning's merge build? |
|
One more commit added as well to address |
|
Was importing into Gretzky. With the latest merge build client of insight. |
|
Trying to reproduce on gretzky, I do see the images from the |
|
Asked @melissalinkert to move the HCS/non-HCS detection to a ticket in |
|
Ticket opened: http://trac.openmicroscopy.org.uk/ome/ticket/12280 |
|
Thanks @melissalinkert (et al). |
joshmoore
added a commit
that referenced
this pull request
May 16, 2014
Add initial support for reading BinaryOnly OME-TIFF datasets
|
--rebased-to #1136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the type detection slightly so that .companion.ome files
are detected as OME-TIFF, not OME-XML (as this makes finding and reading
the corresponding OME-TIFF files much easier). Selecting either a
BinaryOnly OME-TIFF file or the corresponding companion OME-XML file
should result in the entire dataset being read.
Fixes https://trac.openmicroscopy.org.uk/ome/ticket/11951. Sample files were generated from gh-1015, and are in
data_repo/from_skyking/ome-tiff/samples/binary-only.