PrairieReader: add support for inverted X/Y coords #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works by checking the CFG file for the xYStageXPositionIncreasesLeftToRight and/or xYStageYPositionIncreasesBottomToTop properties being set to True, and then inverting all X and/or Y positions respectively if so. With this change, Prairie data with X and/or Y coordinates inverted will still stitch properly using Fiji's "Grid/Collection stitching" plugin.
melissalinkert
added a commit
that referenced
this pull request
Aug 6, 2012
PrairieReader: add support for inverted X/Y coords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works by checking the CFG file for the xYStageXPositionIncreasesLeftToRight and/or xYStageYPositionIncreasesBottomToTop properties being set to True, and then inverting all X and/or Y positions respectively if so.
With this change, Prairie data with X and/or Y coordinates inverted will still stitch properly using Fiji's "Grid/Collection stitching" plugin.
Please note, however, that there is one pending change necessary in PrairieReader before this will work completely correctly. At the moment, PrairieReader populates the OME MetadataStore before parsing the CFG file which inverts the stage coordinates. So the OME metadata is never properly adjusted with the inverted coordinates. Hence, the data will still stitch backwards by default.
Refactoring the PrairieReader to populate OME metadata after the CFG file is fully parsed will address this issue. But in the meantime, this change to PrairieReader still gets us closer to supporting the stage coordinate inversion feature.