New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modulo support for LI-FLIM data #1164
Conversation
Phases are added to ModuloT; frequencies are added to ModuloZ. This is consistent with how phases/frequencies are handled in other formats. Fixes #12290.
The series count is now at most 2, so extra bookkeeping to divide primary images from background images is not necessary.
Relaunched travis (connection reset to maven central) |
One query: for The 12 planes of QA 9236's primary image come through as 12 × t, so apart from the above query this looks good to merge. |
If I open |
@pwalczysko, could you see if you can see a difference on (@melissalinkert: I don't know if the CI jobs already reassure that there has been no regression here.) |
Looks like an Insight bug. @mtbc is filing a ticket, thanks. |
So, this PR is good to merge. |
Add modulo support for LI-FLIM data
--rebased-to #1197 |
Fixes http://trac.openmicroscopy.org.uk/ome/ticket/12290. Phase and frequency dimensions in LI-FLIM files are now stored in the appropriate Modulo annotation, rather than being stored as separate series/Images.
To test, verify that QA 9236 has two Images when imported - the first should contain 12 planes (for 12 phases), and the second should contain a single plane (the background image).
I would suggest also checking other datasets from the
data_repo/from_skyking/li-flim
directory, as many of those files are also multi-phase/multi-frequency datasets which have now had their import behavior changed. In all cases, I would expect no more than 2 Images to appear after import.