New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disabled file grouping for Micro-Manager and OME-TIFF #1687
Fix disabled file grouping for Micro-Manager and OME-TIFF #1687
Conversation
For both formats, if a TIFF file is chosen and file grouping is disabled, then the file will be treated as a regular TIFF. Some metadata will be unavailable (as is expected when file grouping is disabled), but the images will be more quickly accessible.
return isSingleFile(metaFile); | ||
} | ||
catch (Exception e) { | ||
LOGGER.debug("", e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing debug message?
The source changes looks OK, I'll test them shortly. Does the corresponding change want making to the C++ OME-TIFF reader? |
Eventually, yes, but it doesn't necessarily need to happen before 5.1.0. |
Looks fine for both micromanager and OME-TIFF. Should they be falling back to the regular TIFF reader? I see it using the micromanager/OME-TIFF reader with grouping disabled in both cases. I thought isThisType would be returning false here and it would fall back to TiffReader. |
Yes, it should be using the regular TIFF reader if grouping is disabled. Can you paste the exact command you're using? |
It's using TiffDelegateReader underneath so maybe it's OK. I thought the "Checking file format [...]" would have changed as well though if isThisType was false?
|
OK, that's expected then. The |
@melissalinkert OK, in that case it's looking fine and good to merge. |
Fix disabled file grouping for Micro-Manager and OME-TIFF
--no-rebase |
For both formats, if a TIFF file is chosen and file grouping is
disabled, then the file will be treated as a regular TIFF.
Some metadata will be unavailable (as is expected when file grouping is
disabled), but the images will be more quickly accessible.
See http://lists.openmicroscopy.org.uk/pipermail/ome-users/2015-March/005124.html.
I was testing with
micromanager/scott/MM_1.4/Pos1
as it's the largest Micro-Manager dataset we have;showinf -nopix -nogroup
on one of the TIFF files with this PR should be significantly faster with this PR, and result in only the chosen file being read.