Preserve the pixel type for floating-point thumbnails #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The head does indeed look fine: The kitten from the same directory looks less happy, but perhaps that's outwith this PR: |
|
The issue with the kitten is indeed preexisting, so no regression there, and for the head it's a definite improvement. 👍 |
melissalinkert
added a commit
that referenced
this pull request
Apr 14, 2015
Preserve the pixel type for floating-point thumbnails
|
--no-rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://trac.openmicroscopy.org/ome/ticket/6833.
To test, run:
and verify that both produce an image with no exception, and that the latter is a reasonable-looking thumbnail of the former.