Fix SSS timestamp parsing #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This all seems fine - I don't see any problem with the new timestamp values. Only slight issue is that IPWReader, QuesantReader, and TillVisionReader will still need to be updated (due to use of DateTools.formatDate), but that's fine to happen post-5.1.1. |
melissalinkert
added a commit
that referenced
this pull request
Apr 21, 2015
Fix SSS timestamp parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://trac.openmicroscopy.org/ome/ticket/12810
This commit is a follow-up of #1508 and
LeicaReaderas anotherDateTools.getDate()helper methodDateTools.getDate()with/without millliseconds handlingSSSformat and uses the newDateTools.getDate()helperTo test this PR, check timestamps/dates from the various readers modified by this PR are correctly read. All other readers mentioned in the ticket above should also be checked. As far as I could tell
SSSis used for formatting not parsing purposes so they should not need any special handling.