Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeiss CZI: fix assembly of overlapping tiles #1787

Merged
merged 2 commits into from May 18, 2015

Conversation

melissalinkert
Copy link
Member

Fixes https://trac.openmicroscopy.org/ome/ticket/12843.

To test, import the file from zeiss-czi/sebastian/12843 into OMERO; wait for the pyramid to be generated, then compare the resulting image with what is shown in Zeiss' Zen software.

@ghost
Copy link

ghost commented May 11, 2015

Testing on trout; still generating pyramids after 6 hours. This looks like it might be a more general OMERO regression.

@melissalinkert
Copy link
Member Author

Pushed one more commit to fix test failures noted in https://ci.openmicroscopy.org/view/Bio-Formats/job/BIOFORMATS-5.1-merge-full-repository/485/

@mtbc
Copy link
Member

mtbc commented May 12, 2015

We have a Travis failure.

@melissalinkert
Copy link
Member Author

Restarted.

@ghost
Copy link

ghost commented May 13, 2015

Pyramids are now being generated and they do match what I see in Zen Blue. Incidentally, do we actually need to generate pyramids or does the CZI already contain them? Over a network drive, Zen loaded the zoomed-out view and smoothly zoomed in and out across the whole image, making it look like it already had the data to hand.

Looks good to merge if the jobs are all green now.

@melissalinkert
Copy link
Member Author

Using the pyramids may be possible in the future, but is outside the scope of this PR.

melissalinkert added a commit that referenced this pull request May 18, 2015
Zeiss CZI: fix assembly of overlapping tiles
@melissalinkert melissalinkert merged commit 5943cc3 into ome:develop May 18, 2015
@joshmoore joshmoore added this to the 5.1.2 milestone May 27, 2015
@melissalinkert melissalinkert deleted the 12843 branch January 28, 2016 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants