-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OME-TIFF: allow BigTIFF extensions during export #1790
Conversation
This allows switching to BigTIFF without using the setBigTiff API method.
This works with bfconvert, but not with the ImageJ export dialogue. Looks like the readers.txt and writers.txt are not up-to-date with the reader and writer extensions? Suggested fix is below, but note I didn't see any change to the exporter extension list even after making this change--it worked for plain TIFF, but not for OME-TIFF--is something additional required?
Not sure why |
The extensions listed in readers.txt and writers.txt have no bearing on the functionality here - everything after a I haven't been able to duplicate the problem with ImageJ so far - could you please verify that what you have installed in ImageJ contains this change? |
@melissalinkert I just did an ant build of develop+this branch and copied loci_tools.jar into the plugins dir of a stock ImageJ tree (1.49b). I didn't realise the extensions were comments, I thought it was part of the file format. In the Exporter dialogue, the Files of Type combobox has TIFF with five extensions (tif tiff tf2 tf8 btf) but OME-TIFF only has two (ome.tif ome.tiff). I'll double-check I'm using the right jar just in case I'm doing something stupid. |
I assume there is no bio-formats_plugins.jar or bioformats_package.jar present in the ImageJ plugins directory? Does If so, could you please describe exactly what you did and in what way it doesn't work? The new extensions do show up in the |
@melissalinkert OK, it was just me being stupid. Everything works correctly and it looks fine to merge. |
OME-TIFF: allow BigTIFF extensions during export
This allows switching to BigTIFF without using the setBigTiff API method.
See https://trello.com/c/1q2GATUh/171-bigtiff-extensions-for-ome-tiff.
To test, verify that converting any file to a file with the
.ome.btf
,.ome.tf2
, or.ome.tf8
extension via bfconvert or ImageJ results in a BigTIFF file. When using bfconvert, the output should show a message similar toSwitching to BigTIFF based on extension
. The converted files should be readable, and showinf should identify them as being OME-TIFF files.