Leica SCN: do not report more resolutions than there are IFDs #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with snoopycrimecop@339ce51. The SCN file from QA 11049 is correctly initialized with 3 series corresponding to the different resolutions. Additionally this change does not destabilize SCN files as shown in https://ci.openmicroscopy.org/job/BIOFORMATS-5.1-merge-full-repository/590/. Ready to merge. |
melissalinkert
added a commit
that referenced
this pull request
Aug 26, 2015
Leica SCN: do not report more resolutions than there are IFDs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://trac.openmicroscopy.org/ome/ticket/12864.
To test, use the file from QA 11049. Without this change,
showinfshould throw an exception as in the ticket; with this changeshowinfshould report 3 series (to matchtiffinfo *.scn | grep -c "TIFF Directory"), all of which should be viewable withshowinf/ImageJ.