New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageJ plugin - Group files Exception #1967
Conversation
…lly' options selected A test case and steps to reproduce are linked from the ticket. https://trac.openmicroscopy.org/ome/ticket/12941 Issues included: - IndexOutOfBoundsException when both options selected in Main Dialog - For certain file formats the regular expression and 'file contains' file patterns were not being implied - Entering incorrect values into the Dimensions setting of the FilePatternDialog resulted in a 'File is not of a supported format' error Solution: - IndexOutOfBoundsException resolved in ImportProcess by reading the group files option. When both options are selected then group files is not automatically the inverse of ungroup files - For file formats that have a fileGroupOption of FormatTools.MUST_GROUP the second FilePatternDialog is skipped and replaced with an ImageJ message box informing the user why file pattern options are not available, stating "Image specifications state that files of this given format cannot be handled separately and must be grouped according to supporting metadata". A new importer option flag was added to test and store the must group condition
…iles New functionality should be: Neither option selected - Open group files - No group files dialog Open individually selected - Open individually Group files with similar names selected - Open group files - message popup instead of group dialog if must group Both options selected - Open group files - message popup instead of group dialog if must group
@dgault:
|
@jburel
The question is whether or not it is better to have that popup informing the user why the file stitching options are not being presented as normal, or if the popup is too intrusive then perhaps it would be best to leave it out all together and go straight to the series options screen. I've attached an image below to clearer demonstrate the 2 possible options. If there is a preference for the second option then the PR can be easily updated.
|
@dgault: no problem at all, The description of the PR was already well documented |
Having an extra window is probably not a bad thing and does not break the "usual" ImageJ workflow (several windows can pop up when performing a task e.g. export as OME-TIFF) |
Changing text to make it clearer to the user that File Stitching Options are being skipped
Updated the text being displayed to try and make it clearer to the user that the file stitching options are not available for the selected files. |
Does this need to be relisted? |
I was planning to do it yesterday afternoon |
|
Fixed spelling mistake and inserting new line for second sentence
Text display is improved. typo fixed. Just noticed a missing dot at the end of the second sentence. |
Missing full stop added
@dgault thanks. Good to merge |
ImageJ plugin - Group files Exception
ImageJ plugin - Exception when both 'group files' and 'open individually' options selected
A test case and steps to reproduce are linked from the ticket.
https://trac.openmicroscopy.org/ome/ticket/12941
Splitting from #1964
Issues included:
file patterns were not being implied
FilePatternDialog resulted in a 'File is not of a supported format'
error
Solution:
group files option. When both options are selected then group files is
not automatically the inverse of ungroup files
the second FilePatternDialog is skipped and replaced with an ImageJ
message box informing the user why file pattern options are not
available, stating "Image specifications state that files of this given
format cannot be handled separately and must be grouped according to
supporting metadata". A new importer option flag was added to test and
store the must group condition