New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micromanager: *_metadata.txt and 51123 tag parsing #2226
Conversation
Also the beginnings of stack file detection, though openBytes needs more work to read from IFDs beyond the first.
Tested the current behavior using the Bio-formats 5.1.7 command-line tools and the provided dataset. The following commands:
all fail with a Using the command-line tools with this PR included, running
Also tested in OMERO by importing the four filesets. Without this PR, the command-line import succeeds with the following summary:
With this PR included, all files are uploaded and 4 images are created at import as expected:
and the extended metadata is correctly exposed in the Metadata tab. The repository subset test job successfully passes on all Micro-manager filesets in the data repository. However, this PR causes issues on the full repository job when creating the list of files. Additionally, it causes issues when running tests against our OME-TIFF samples. |
Fix pushed for the exception exposed by https://ci.openmicroscopy.org/view/Failing/job/BIOFORMATS-DEV-merge-full-repository/62/console. The subset job failures appear to be as a result of gh-2229, so not addressed here. |
https://ci.openmicroscopy.org/job/BIOFORMATS-DEV-merge-repository-subset/107 validates this PR (independently of gh-2229). Merging this for rebasing onto As a documentation follow-up, the content of |
Micromanager: *_metadata.txt and 51123 tag parsing
--rebased-to #2232 |
This fixes several issues with the new datasets from Thomas Julou - see https://github.com/openmicroscopy/data_repo_config/pull/76 for configuration and gh-2213 for discussion.
For each of the four new datasets, check that
showinf
on the*metadata.txt
file shows images without an error (with this change). Without this change,showinf
ontest_sep/Pos0/metadata.txt
should work, but all others will throw an exception.For
test2_sep
,test_stack
, andtest2_stack
, check each image (this may be easier in ImageJ) and verify that each image is unique and not blank.For
test_stack
andtest2_stack
, the 51123 tag should be parsed for each plane. Compare the original metadata tables with and without this change; there should be several newPlane #...
keys with this change.