New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zeiss CZI: fixes for files with multiple mosaics and positions #2305
Conversation
BF : SeriesCount = 8. SizeX = 33291, SizeY = 20493 (Whole Image split into 8 series) I went through the PositionX and PositionY values to calculate the maximum values for the montage, maximum Value of PositionX = 102816 , now adding the sizeX to this gives : (102816+33291) = 136107 which is lesser than 136283 (From Zen Lite). and maximum Value PositionY = 23868 , now adding the sizeY to this gives : (23868 + 20493) = 44361 which is lesser than 44372(From Zen Lite). So, in conclusion: The pixel data seems to fit into the image montage (if stitched together), but seems to be missing a few pixels at the edges. I am unsure if this expected, will leave it up to @melissalinkert to decide. All the metadata matches between BF and ZenLite for this image. |
Assuming that the image display has been validated against Zen, and given that we don't stitch scenes (the 8 series in this case) where Zen does, then that's more or less what I'd expect. To do the arithmetic a different way, our 8 series corresponds to 4x2 stitched tiles == 33291x4 x 20493x2 == 133164 x 40986, so within the bounds of the dimensions reported by Zen. |
@bramalingam: what is your call on image display validation? Could we paste screenshots from Bio-Formats and Zen into the PR comments? |
That will not help, cause the image has low contrast and it will be hard to infer anything from those screenshots. Melissa knows better about this, and I would suggest we go ahead and merge this. |
--rebased-to #2329 |
--rebased-to #2330 |
Might be a stupid question, but is this somewhere available as a pre-release build? Jenkins or whatever? We'd be keen on testing! 😉 |
@ehrenfeu: this bug fix should be soon released as 5.1.9. If you are keen on testing pre-release Continuous Integration builds, you should be able to download them from the latest 5.1 CI build which includes the backported PR. See also https://www.openmicroscopy.org/site/support/contributing/ci-bio-formats.html for more information. |
See http://lists.openmicroscopy.org.uk/pipermail/ome-devel/2016-February/003588.html
To test, use the file in
curated/zeiss-czi/niko
(it will be ~100GB). The images are quite large; the easiest first test would be to select a few ~2kx2k tiles and check the display in ImageJ vs Zeiss' ZEN. It would be good to try importing into OMERO as well, to validate that all of the pixel data is read correctly, but this will take a while as pyramids will need to be generated.Configuration PR is: https://github.com/openmicroscopy/data_repo_config/pull/96