Leica LIF: fix multi-dimensional data from color cameras #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #13112. This fixes the case when a color camera is used (so each plane has 3 RGB channels), and multiple channels are acquired potentially in addition to multiple timepoints and/or Z sections.
|
Code changes make sense and the two QA files now open without any of the errors that were thrown before applying the PR. The images look and display as expected also. Config PR has also been tested and is green - https://ci.openmicroscopy.org/view/Bio-Formats-DEV/job/BIOFORMATS-DEV-merge-repository-subset/207/ Changes look good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://trac.openmicroscopy.org/ome/ticket/13112.
This fixes the case when a color camera is used (so each plane has 3 RGB
channels), and multiple channels are acquired potentially in addition to
multiple timepoints and/or Z sections.
To test, use the files from QA 16911 and QA 16919. Compare the images as shown in Leica's LAS X or LAS AF Lite software against what is shown by ImageJ with and without this change. Also verify that with this change, no error messages are shown when opening either file in ImageJ.