Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PicoQuant reader to always buffer data. #2332

Merged
merged 6 commits into from Apr 12, 2016
Merged

Conversation

imunro
Copy link
Contributor

@imunro imunro commented Apr 7, 2016

For very large files this reader was prohibitively slow. See https://trac.openmicroscopy.org/ome/ticket/13183

Test using curated .bin files. A larger example is available in QA 17134. Should now load in < 1min.

@sbesson sbesson added the develop label Apr 8, 2016
@dgault
Copy link
Member

dgault commented Apr 11, 2016

Code changes look good to me, default sizes seem sensible and I have no further suggestions for improvements.

Tested against files in curated as well as QA-17134, all files open and display correctly and do so in an improved timeframe (< 1 min).

The sample file from QA-17134 should be added to inbox and data repo PR opened with a config for it. I don't mind opening the config PR if its easier.

@imunro
Copy link
Contributor Author

imunro commented Apr 11, 2016

Thanks. If you could do that it would be great. I do it sufficiently infrequently that I tend to forget steps.

@dgault
Copy link
Member

dgault commented Apr 11, 2016

Related config PR for QA-17134 is https://github.com/openmicroscopy/data_repo_config/pull/105

@dgault
Copy link
Member

dgault commented Apr 12, 2016

Since the config PR is now green this should be good to merge - openmicroscopy/data_repo_config#105

The ticket https://trac.openmicroscopy.org/ome/ticket/13183 can also be closed, I dont appear to have permission to do so

@sbesson
Copy link
Member

sbesson commented Apr 12, 2016

See https://ci.openmicroscopy.org/job/BIOFORMATS-DEV-merge-repository-subset/204/console for the automated tests run against the whole set of picoquant sample files (incl. QA 17134).

@sbesson sbesson merged commit dcaced7 into ome:develop Apr 12, 2016
@imunro imunro deleted the PQBIN2 branch April 12, 2016 20:18
@sbesson sbesson added this to the 5.2.0 milestone Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants